Update build-node-packages.yml

.github/workflows/build-node-packages.yml

@@ -28,4 +28,4 @@ jobs:
       tool-name: "node"
       tool-version: ${{ inputs.VERSION || '18.12.0' }}
       publish-release: ${{ inputs.PUBLISH_RELEASES || false }}
-    secrets: inherit
+    secrets: inherit

tests/Node.Tests.ps1

@@ -1,23 +1,20 @@
 Import-Module (Join-Path $PSScriptRoot "../helpers/pester-extensions.psm1")
 
+BeforeAll {
+    function Get-UseNodeLogs {
+        # GitHub Windows images don't have `HOME` variable
+        $homeDir = $env:HOME ?? $env:HOMEDRIVE
+        $logsFolderPath = Join-Path -Path $homeDir -ChildPath "runners/*/_diag/pages" -Resolve
 
+        $useNodeLogFile = Get-ChildItem -Path $logsFolderPath | Where-Object {
+            $logContent = Get-Content $_.Fullname -Raw
+            return $logContent -match "setup-node@v"
+        } | Select-Object -First 1
+        return $useNodeLogFile.Fullname
+    }
+}
 
 Describe "Node.js" {
-
-    BeforeAll {
-        function Get-UseNodeLogs {
-            # GitHub Windows images don't have `HOME` variable
-            $homeDir = $env:HOME ?? $env:HOMEDRIVE
-            $logsFolderPath = Join-Path -Path $homeDir -ChildPath "runners/*/_diag/pages" -Resolve
-    
-            $useNodeLogFile = Get-ChildItem -Path $logsFolderPath | Where-Object {
-                $logContent = Get-Content $_.Fullname -Raw
-                return $logContent -match "setup-node@v"
-            } | Select-Object -First 1
-            return $useNodeLogFile.Fullname
-        }
-    }
-    
     It "is available" {
         "node --version" | Should -ReturnZeroExitCode
     }
@@ -37,24 +34,24 @@ Describe "Node.js" {
         $nodePath.startsWith($expectedPath) | Should -BeTrue -Because "'$nodePath' is not started with '$expectedPath'"
     }
 
-     It "cached version is used without downloading" {
-
-       if ($env:RUNNER_TYPE -eq "self-hosted") {
+    It "cached version is used without downloading" {
+        if ($env:RUNNER_TYPE -eq "GitHub") {
+            # Analyze output of previous steps to check if Node.js was consumed from cache or downloaded
+            $useNodeLogFile = Get-UseNodeLogs
+            $useNodeLogFile | Should -Exist
+            $useNodeLogContent = Get-Content $useNodeLogFile -Raw
+            $useNodeLogContent | Should -Match "Found in cache"
+        } else {
             # Get the installed version of Node.js
             $nodeVersion = Invoke-Expression "node --version"
             # Check if Node.js is installed
             $nodeVersion | Should -Not -BeNullOrEmpty
             # Check if the installed version of Node.js is the expected version
             $nodeVersion | Should -Match $env:VERSION
-        }else {
-            # Analyze output of previous steps to check if Node.js was consumed from cache or downloaded
-            $useNodeLogFile = Get-UseNodeLogs
-            $useNodeLogFile | Should -Exist
-            $useNodeLogContent = Get-Content $useNodeLogFile -Raw
-            $useNodeLogContent | Should -Match "Found in cache"
-        } 
+        }
     }
-    
+
+
     It "Run simple code" {
         "node ./simple-test.js" | Should -ReturnZeroExitCode
     }