mirror of
https://github.com/softprops/action-gh-release.git
synced 2026-03-18 12:19:01 +08:00
fix: release marked as 'latest' despite make_latest: false (#715)
* fix: pass make_latest when finalizing release The finalizeRelease function was not passing the make_latest parameter when publishing a release (setting draft: false). According to the GitHub API, make_latest defaults to `true` for newly published releases, so `make_latest: false` was being ignored. Ref: https://github.com/octokit/openapi-types.ts/blob/main/packages/openapi-types/types.d.ts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: rebuild bundle after make_latest rebase Signed-off-by: Rui Chen <rui@chenrui.dev> --------- Signed-off-by: Rui Chen <rui@chenrui.dev> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Rui Chen <rui@chenrui.dev>
This commit is contained in:
@@ -62,6 +62,7 @@ export interface Releaser {
|
||||
owner: string;
|
||||
repo: string;
|
||||
release_id: number;
|
||||
make_latest: 'true' | 'false' | 'legacy' | undefined;
|
||||
}): Promise<{ data: Release }>;
|
||||
|
||||
allReleases(params: { owner: string; repo: string }): AsyncIterable<{ data: Release[] }>;
|
||||
@@ -182,12 +183,18 @@ export class GitHubReleaser implements Releaser {
|
||||
return this.github.rest.repos.updateRelease(params);
|
||||
}
|
||||
|
||||
async finalizeRelease(params: { owner: string; repo: string; release_id: number }) {
|
||||
async finalizeRelease(params: {
|
||||
owner: string;
|
||||
repo: string;
|
||||
release_id: number;
|
||||
make_latest: 'true' | 'false' | 'legacy' | undefined;
|
||||
}) {
|
||||
return await this.github.rest.repos.updateRelease({
|
||||
owner: params.owner,
|
||||
repo: params.repo,
|
||||
release_id: params.release_id,
|
||||
draft: false,
|
||||
make_latest: params.make_latest,
|
||||
});
|
||||
}
|
||||
|
||||
@@ -440,6 +447,7 @@ export const finalizeRelease = async (
|
||||
owner,
|
||||
repo,
|
||||
release_id: release.id,
|
||||
make_latest: config.input_make_latest,
|
||||
});
|
||||
|
||||
return data;
|
||||
|
||||
Reference in New Issue
Block a user